Small updates to BTAS #182
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmp5VT
commented
Jan 22, 2025
kmp5VT
commented
Jan 22, 2025
Member
|
@kmp5VT does this need the TODOs to be completed? |
Contributor
Author
|
@evaleev I updated the unit-tests for the new features so this should be ready to merge, provided CI has no issues. |
evaleev
reviewed
Jun 11, 2025
| } | ||
|
|
||
| if (verbose_) { | ||
| std::cout << rank_ << "\t" << iter_ << "\t" << std::setprecision(16) << diff << std::endl; |
Member
There was a problem hiding this comment.
need to use proper logging ... in another PR
evaleev
approved these changes
Jun 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some factors need to be implemented more universally, such as the generate random matrix function. A few new convergence checkers such as, no checking and two that look at the difference between approximations between iterations, instead of the global fit.
TODO