feat: add Docker container build configuration#403
Open
CyrilCh wants to merge 9 commits intoValueCell-ai:mainfrom
Open
feat: add Docker container build configuration#403CyrilCh wants to merge 9 commits intoValueCell-ai:mainfrom
CyrilCh wants to merge 9 commits intoValueCell-ai:mainfrom
Conversation
- Add docker-compose.yml for orchestrating frontend and backend services - Add Dockerfile.backend for building backend container - Add Dockerfile.frontend for building frontend container - Add .dockerignore to exclude unnecessary files - Add docker documentation and scripts - Add database migration script
…uction_id, avg_exec_price, realized_pnl, etc.)
hazeone
reviewed
Nov 21, 2025
hazeone
reviewed
Nov 21, 2025
hazeone
reviewed
Nov 21, 2025
Contributor
hazeone
left a comment
hazeone
left a comment
There was a problem hiding this comment.
Thank you for your Pull Request! Please update the content to the English version and remove the processing file.
Note: We will support the ValueCell App on both MAC and Windows platforms. All configurations will be managed via a GUI and stored in local files. So maybe you should give a test for the docker environment. Reference: https://github.com/ValueCell-ai/valuecell/blob/main/python/valuecell/__init__.py
… files - Changed the database volume mapping in `docker-compose.yml` to use a dedicated `data` directory. - Added a new environment variable `VALUECELL_SQLITE_DB` for SQLite database configuration. - Updated `Dockerfile.backend` to include an entrypoint script for database initialization. - Removed obsolete `daemon.json.example` and related documentation files. - Enhanced database path resolution in `db.py` to support both URL and filesystem path formats.
Author
|
Thank you for your review and valuable feedback! I have completed the following updates as requested:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add docker-compose.yml for orchestrating frontend and backend services
Add Dockerfile.backend for building backend container
Add Dockerfile.frontend for building frontend container
Add .dockerignore to exclude unnecessary files
Add docker documentation and scripts
Add database migration script
📝 Pull Request Template
1. Related Issue
Closes # (issue number)
Type of Change (select one)
Type of Change: Other: docker env_
3. Description
环境一致性：容器化确保开发、测试、生产环境一致
简化部署：docker-compose up 一键启动
开发体验：热重载支持，代码修改即时生效
性能优化：使用国内镜像源加速构建
4. Testing
5. Checklist