feat: Maintain Stop Gain/Loss Prices Across LLM Decisions#576
Open
lukecold wants to merge 2 commits intoValueCell-ai:mainfrom
Open
feat: Maintain Stop Gain/Loss Prices Across LLM Decisions#576lukecold wants to merge 2 commits intoValueCell-ai:mainfrom
lukecold wants to merge 2 commits intoValueCell-ai:mainfrom
Conversation
7954ac8 to
b60ae3d
Compare
This PR implements robust management for Stop Gain/Loss prices, ensuring these critical protective limits are **maintained and consistently applied** across trading sessions and subsequent LLM decisions. * **LLM Definition:** LLM response extended to include new Stop Gain/Loss price fields. * **Persistent Storage:** Defined stop prices are stored in session memory and persisted via database snapshot. * **Session Continuity:** Loads persisted stop prices when resuming a session, restoring trading strategy limits. * **Informed Decisions:** Existing stop prices are fed back into the LLM context to inform and assist subsequent trading actions.
b60ae3d to
ef6b3dc
Compare
Collaborator
|
Thanks for the PR! However, creating a separate table for Looking at the Since the For example, stop_prices in metadata could look like this: {
"stop_prices": {
"BTC-USDT": { "stop_gain": 50000, "stop_loss": 40000, "note": "..." },
"ETH-USDT": { "stop_gain": 3000, "stop_loss": 2000 }
}
}Please let me know what you think. |
6eb3476 to
f2cf752
Compare
f2cf752 to
2f854e5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Pull Request Template
1. Related Issue
Closes # (issue number)
2. Type of Change (select one)
Type of Change: New Feature
3. Description
This PR implements robust management for Stop Gain/Loss prices, ensuring these critical protective limits are maintained and consistently applied across trading sessions and subsequent LLM decisions.
4. Testing
5. Checklist