Revert token image to idle when combat ends#4
Open
mcbalston wants to merge 3 commits intoVanirDev:mainfrom
Open
Revert token image to idle when combat ends#4mcbalston wants to merge 3 commits intoVanirDev:mainfrom
mcbalston wants to merge 3 commits intoVanirDev:mainfrom
Conversation
Added an additional hook to trigger change of icon state (to idle) on end of combat.
This reverts commit 8e971b8.
Added an additional hook (on deleteCombat) to trigger change of icon state (to idle) on end of combat.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a great little module, but I found that token images weren't reverting to out-of-combat (idle) state when a combat ends.
This small addition should address that. It triggers a change whenever a combat ends. This can be when the 'End Combat' button at the bottom of the combat tracker is pressed, or the 'Delete Encounter' trash icon at the top of the combat tracker is pressed.