Enable embeds of any other video embed type#81
Open
Enovale wants to merge 3 commits intoVendicated:mainfrom
Open
Enable embeds of any other video embed type#81Enovale wants to merge 3 commits intoVendicated:mainfrom
Enovale wants to merge 3 commits intoVendicated:mainfrom
Conversation
Also cleanup code a bit.
Vendicated
reviewed
Jun 17, 2024
...Embeds/src/main/kotlin/dev/vendicated/aliucordplugins/betterplatformembeds/PlayableEmbeds.kt
Outdated
Show resolved
Hide resolved
Vendicated
reviewed
Jun 17, 2024
| val playButton = cardView.findViewById<View>(Utils.getResId("chat_list_item_embed_image_icons", "id")) | ||
| playButton.visibility = View.GONE | ||
| chatListItemEmbedImage.visibility = View.GONE | ||
| val posterUrl = embed.image?.url |
Owner
There was a problem hiding this comment.
double check that this is discord media proxy url and not the external url, otherwise this can be used to ip log
Author
There was a problem hiding this comment.
When I use the ProxyUrl, the videos don't load, that's why I wasn't using them. I don't know what's wrong with it
Author
There was a problem hiding this comment.
The thumbnail can sometimes be proxied however. I'll make sure to enable that, but it can't always be proxied. Sometime's its fetched by preloading the metadata in the video player.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use a <video> tag to embed any VideoEmbed type.
Also cleaned up the code a bit.