Refactoring mintermization to MintermizationDomain#355
Draft
martinhruska wants to merge 20 commits intodevelfrom
Draft
Refactoring mintermization to MintermizationDomain#355martinhruska wants to merge 20 commits intodevelfrom
martinhruska wants to merge 20 commits intodevelfrom
Conversation
… the bloody bdd manager
…rehensible for stupid computer scientists
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## devel #355 +/- ##
==========================================
+ Coverage 71.70% 73.16% +1.45%
==========================================
Files 30 32 +2
Lines 3644 3536 -108
Branches 843 805 -38
==========================================
- Hits 2613 2587 -26
+ Misses 736 649 -87
- Partials 295 300 +5
☔ View full report in Codecov by Sentry. |
Adda0
reviewed
Oct 2, 2023
Collaborator
Adda0
left a comment
There was a problem hiding this comment.
The changes look good to me overall. @kilohsakul Is this what you envisioned?
Collaborator
|
When the PR is finished, @tfiedor or I will fix the binding before merging the PR. |
tfiedor
approved these changes
Oct 6, 2023
Co-authored-by: David Chocholatý <chocholaty.david@protonmail.com>
Co-authored-by: David Chocholatý <chocholaty.david@protonmail.com>
Co-authored-by: Tomas Fiedor <ifiedortom@fit.vutbr.cz>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR indtroduces the following changes:
BDDDomainwhich encapsulatesBDDs and is an example for the possible future domains for mintermization.