Conversation
Adda0
left a comment
Adda0
left a comment
There was a problem hiding this comment.
LGTM overall according to what we have agreed on as of now. We can change something again later.
| if (str_algo == "hopcroft") { | ||
| /* default */; | ||
| } else if (str_algo == "brzozowski") { | ||
| algo = algorithms::minimize_brzozowski; |
There was a problem hiding this comment.
Maybe this should be named make_minimal_dfa_brzozowski()? To show it can be used for NFAs.
There was a problem hiding this comment.
But this will break the naming convention for minimizazion algorithms.
There was a problem hiding this comment.
True, but Brzozowski does not perform minimization as per the definition given by Lukáš. But this is debatable. What does @jurajsic think?
There was a problem hiding this comment.
I do not know, but I realized that this change, that minimize now HAVE to take DFA, might break noodler (and anyone using mata, if such people exists), because before it was assumed it takes nfa and calls brzozowski.
3 participants
This PR: