-
-
Notifications
You must be signed in to change notification settings - Fork 16
1.5.4 - Fix ladder bounding boxes! and bump to 1.5.4 #95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
verifying this rq. |
|
I have it currently on my 1.21.4 LeafMC server. And its working fine on 1.8.9 clients i havent tested in others like 1.12. |
Kichura
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
thats weird its working for me on 1.21.4 i think legacy support does not work on 1.21.10 yet. |
Check if you can resolve this issue for 1.21.10 as otherwise the plugin is useless for 1.21.5+. |
|
sure let me see if its possible for me to make 1.21.10 work give me a few minutes to see what i can do |
|
Just tested it on 1.21.10 and it works. try now |
Kichura
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test has passed.

This issue below was fixed and now the ladders do work on Legacy versions like 1.8 and the error no longer shows up.
[20:47:37 INFO]: [ViaRewind-Legacy-Support] Enabling ViaRewind-Legacy-Support v1.5.3
[20:47:37 ERROR]: [ViaRewind-Legacy-Support] Could not fix ladder bounding box.
java.lang.NoSuchMethodException: net.minecraft.world.level.block.Block.boxZ(double,double,double)
at java.base/java.lang.Class.getDeclaredMethod(Class.java:2848) ~[?:?]
at io.papermc.reflectionrewriter.runtime.AbstractDefaultRulesReflectionProxy.getDeclaredMethod(AbstractDefaultRulesReflectionProxy.java:95) ~[reflection-rewriter-runtime-0.0.3.jar:?]
at io.papermc.paper.pluginremap.reflect.PaperReflectionHolder.getDeclaredMethod(Unknown Source) ~[leaf-1.21.4.jar:1.21.4-524-8757c36]
at ViaRewind-Legacy-Support-1.5.3.jar/com.viaversion.viarewind.legacysupport.feature.BlockCollisionChanges.fixLadder(BlockCollisionChanges.java:67) ~[ViaRewind-Legacy-Support-1.5.3.jar:?]
at ViaRewind-Legacy-Support-1.5.3.jar/com.viaversion.viarewind.legacysupport.BukkitPlugin.enable(BukkitPlugin.java:83) ~[ViaRewind-Legacy-Support-1.5.3.jar:?]
at ViaRewind-Legacy-Support-1.5.3.jar/com.viaversion.viarewind.legacysupport.BukkitPlugin.onEnable(BukkitPlugin.java:51) ~[ViaRewind-Legacy-Support-1.5.3.jar:?]
at org.bukkit.plugin.java.JavaPlugin.setEnabled(JavaPlugin.java:280) ~[leaf-api-1.21.4-R0.1-SNAPSHOT.jar:?]
at io.papermc.paper.plugin.manager.PaperPluginInstanceManager.enablePlugin(PaperPluginInstanceManager.java:202) ~[leaf-1.21.4.jar:1.21.4-524-8757c36]
at io.papermc.paper.plugin.manager.PaperPluginManagerImpl.enablePlugin(PaperPluginManagerImpl.java:109) ~[leaf-1.21.4.jar:1.21.4-524-8757c36]
at org.bukkit.plugin.SimplePluginManager.enablePlugin(SimplePluginManager.java:519) ~[leaf-api-1.21.4-R0.1-SNAPSHOT.jar:?]
at org.bukkit.craftbukkit.CraftServer.enablePlugin(CraftServer.java:675) ~[leaf-1.21.4.jar:1.21.4-524-8757c36]
at org.bukkit.craftbukkit.CraftServer.enablePlugins(CraftServer.java:625) ~[leaf-1.21.4.jar:1.21.4-524-8757c36]
at net.minecraft.server.MinecraftServer.loadWorld0(MinecraftServer.java:746) ~[leaf-1.21.4.jar:1.21.4-524-8757c36]
at net.minecraft.server.MinecraftServer.loadLevel(MinecraftServer.java:491) ~[leaf-1.21.4.jar:1.21.4-524-8757c36]
at net.minecraft.server.dedicated.DedicatedServer.initServer(DedicatedServer.java:389) ~[leaf-1.21.4.jar:1.21.4-524-8757c36]
at net.minecraft.server.MinecraftServer.runServer(MinecraftServer.java:1188) ~[leaf-1.21.4.jar:1.21.4-524-8757c36]
at net.minecraft.server.MinecraftServer.lambda$spin$0(MinecraftServer.java:300) ~[leaf-1.21.4.jar:1.21.4-524-8757c36]
at java.base/java.lang.Thread.run(Thread.java:1583) ~[?:?]