Python 3 support and some fixes #44
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zwpwjwtz
reviewed
Oct 21, 2022
zwpwjwtz
left a comment
zwpwjwtz
left a comment
There was a problem hiding this comment.
This works on my side (Python 3.9.13 + flask 1.1.2 + forgi 2.1.1 + werkzeug 0.16.0).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python 2 is EOL since 01/01/2020, so I converted the python part to be compatible with Python 3 (although I haven't done extensive tests for potential bugs/regressions).
Moreover, I updated some parts in order to be compatible with newer external libraries and added the
requirements.txtfile containing the required libraries to launch the local server (useful for virtualenvs).