[FIX][15.0] to_backend_theme: Fix pad UI goes wrong#21
Open
Ngquang wants to merge 1 commit intoViindoo:15.0from
Open
[FIX][15.0] to_backend_theme: Fix pad UI goes wrong#21Ngquang wants to merge 1 commit intoViindoo:15.0from
pad UI goes wrong#21Ngquang wants to merge 1 commit intoViindoo:15.0from
Conversation
viinbot
added
🚀 Queue
Ngquang
force-pushed
the
v15_imp_to_backend_theme_2
branch
from
8ceb917 to
a898024
Compare
Ngquang
changed the title
pad UI goes wrong
viinbot
added
🚀 Queue
Ngquang
force-pushed
the
v15_imp_to_backend_theme_2
branch
from
a898024 to
9cd5fc0
Compare
viinbot
added
🚀 Queue
Ngquang
force-pushed
the
v15_imp_to_backend_theme_2
branch
from
9cd5fc0 to
de3f03b
Compare
viinbot
added
🚀 Queue
- Currently in Chrome, parent-flex not having a true value so when flex-basis apply, the child don't know what size to compute when size of parent changed. It makes the editor shrink to much and user can not use this editor This PR will fix this problem.
Ngquang
force-pushed
the
v15_imp_to_backend_theme_2
branch
from
de3f03b to
72eafbb
Compare
viinbot
added
🚀 Building
Author
|
@royleviindoo anh ơi, anh xem qua giúp em PR này với ạ. |
viinbot
added
🚩 Done
viinbot
removed
the
🚀 Running
viinbot
added
🚀 Building
Ngquang
changed the title
pad UI goes wrongpad UI goes wrong
Ngquang
changed the title
pad UI goes wrongpad UI goes wrong
viinbot
added
🚀 Queue
Ngquang
changed the title
pad UI goes wrongpad UI goes wrong
Ngquang
changed the title
pad UI goes wrongpad UI goes wrong
viinbot
added
🚀 Queue
viinbot
added
🚩 Done
Author
|
Close PR do không còn bị gặp lại hiện tượng này |
viinbot
added
🚀 Queue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket: https://viindoo.com/web#cids=1&id=7192&model=helpdesk.ticket
-Hiện tại khi mở Note trên Chrome sẽ bị gặp lỗi hiển thị phần edit của
padbị co vào quá nhiều dẫn đến người dùng không thể nhìn được nội dung khi editBefore
Nhưng tình trạng này lại không bị khi mở bằng Firefox, Safari.
Việc này có được đề cập tại đây: https://bugs.chromium.org/p/chromium/issues/detail?id=428049#c11
Chrome và Firefox không cùng engine nên việc render
flex-basissẽ dẫn đến khác nhau.Để xử lí vấn đề này, PR này sẽ gắn giá trị tuyệt đối cho
flex-parentvà cácflex-containernằm trongflex-parentsẽ cần có thêmdisplay:flex, flex:1để chúng có thể co dãn cùng với kích thước của flex-parent.After
PR này sẽ chỉ fix cho repo của mình mà không fix cho Odoo vì từ bản 16 Odoo đã bỏ
pad:https://github.com/odoo/odoo/pull/75768: PR này Odoo cải tiến cho edit collab ở bất kỳ chỗ nào có html fieldhttps://github.com/odoo/odoo/pull/76467: PR này Odoo xoá pad