[IMP][16.0] viin_brand_auth_totp*: Viindoo debranding for module auth_totp*#358
Open
duyquyen96 wants to merge 2 commits intoViindoo:16.0from
Open
[IMP][16.0] viin_brand_auth_totp*: Viindoo debranding for module auth_totp*#358duyquyen96 wants to merge 2 commits intoViindoo:16.0from
duyquyen96 wants to merge 2 commits intoViindoo:16.0from
Conversation
viinbot
added
🚀 Queue
Contributor
|
@duyquyen96 Viindoo Test Suite has failed! |
viinbot
added
🚀 Queue
Contributor
|
@duyquyen96 Viindoo Test Suite has failed! |
Contributor
Author
|
@viinbot rebase |
Contributor
|
@duyquyen96 PR rebased! |
Contributor
Author
|
@viinbot rebuild |
viinbot
added
🚀 Queue
Contributor
|
@duyquyen96 PR in the queue to wait for rebuild! |
viinbot
added
🚀 Building
Contributor
|
@duyquyen96 Viindoo Test Suite has passed! |
Contributor
|
@viinbot rebase |
Contributor
|
@davidtranhp PR rebased! |
viinbot
force-pushed
the
v16_imp_viin_brand_auth_totp
branch
from
c4cdf8c to
3429328
Compare
viinbot
added
🚀 Queue
viinbot
added
🚀 Queue
Contributor
|
@duyquyen96 Viindoo Test Suite has passed! |
Comment on lines
+3
to
+23
| <function name="write" model="ir.model.data"> | ||
| <function name="search" model="ir.model.data"> | ||
| <value | ||
| eval="[('module', '=', 'auth_totp_mail'), ('name', '=', 'mail_template_totp_invite')]" /> | ||
| </function> | ||
| <value eval="{'noupdate': False}" /> | ||
| </function> | ||
|
|
||
| <function name="write" model="mail.template"> | ||
| <value eval="[ref('auth_totp_mail.mail_template_totp_invite')]" /> | ||
| <value | ||
| eval="{'subject': 'Invitation to activate two-factor authentication on your Viindoo account'}" /> | ||
| </function> | ||
|
|
||
| <function name="write" model="ir.model.data"> | ||
| <function name="search" model="ir.model.data"> | ||
| <value | ||
| eval="[('module', '=', 'auth_totp_mail'), ('name', '=', 'mail_template_totp_invite')]" /> | ||
| </function> | ||
| <value eval="{'noupdate': True}" /> | ||
| </function> |
Collaborator
There was a problem hiding this comment.
@duyquyen96 anh thấy thì chỉ cần như này là đủ, để chỉ ghi đè 1 lần khi cài module này lên, những lần sau upgrade sẽ không bị
nếu làm như của em, mỗi lần upgrade đều ghi đè lại, giả xử khách sửa subject thành 1 cái khác, nâng cấp module sẽ lại bị sửa => chưa đúng ý nghĩa của noupdate
kiểm tra cả dịch nữa nhé
Suggested change
| <function name="write" model="ir.model.data"> | |
| <function name="search" model="ir.model.data"> | |
| <value | |
| eval="[('module', '=', 'auth_totp_mail'), ('name', '=', 'mail_template_totp_invite')]" /> | |
| </function> | |
| <value eval="{'noupdate': False}" /> | |
| </function> | |
| <function name="write" model="mail.template"> | |
| <value eval="[ref('auth_totp_mail.mail_template_totp_invite')]" /> | |
| <value | |
| eval="{'subject': 'Invitation to activate two-factor authentication on your Viindoo account'}" /> | |
| </function> | |
| <function name="write" model="ir.model.data"> | |
| <function name="search" model="ir.model.data"> | |
| <value | |
| eval="[('module', '=', 'auth_totp_mail'), ('name', '=', 'mail_template_totp_invite')]" /> | |
| </function> | |
| <value eval="{'noupdate': True}" /> | |
| </function> | |
| <data noupdate="1"> | |
| <record id="auth_totp_mail.mail_template_totp_invite" model="mail.template"> | |
| <field name="subject">Invitation to activate two-factor authentication on your Viindoo account</field> | |
| </record> | |
| </data> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Screen.Recording.2023-06-15.at.11.07.12.mov
I confirm I have read guidelines at https://docs.google.com/document/d/1Ru1C9XK93BNmXX1nKvTMt63QMBIOBy2NSdKosEwvuy4/edit