Add asyncio versions of steps for build_from_scratch integration#21
Open
jpwang2 wants to merge 5 commits intoVipyr:masterfrom
Open
Add asyncio versions of steps for build_from_scratch integration#21jpwang2 wants to merge 5 commits intoVipyr:masterfrom
jpwang2 wants to merge 5 commits intoVipyr:masterfrom
Conversation
Author
|
@dansvo @edmcquade |
|
@jpwang2 Can you describe the purpose of this change in detail? |
manistal
requested changes
Sep 19, 2019
manistal
left a comment
manistal
left a comment
There was a problem hiding this comment.
Needs a detailed description and purpose.
Author
|
Hi Miguel, I've updated the initial description, is that more in line with what you were thinking? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add variations of the Graph, Product, and Step using asyncio instead of python threading. Uses the same communication method of setting Event flags as original bazaar, only we are using asyncio versions instead of the analogous threading version. This is to allow for easy integration into the aod script which already heavily uses asyncio.