Merged
Conversation
Owner
|
Thanks. I appreciate it, as always. 🙏🏻 So, except for the action build, i merged your PR, all seems to working. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At present KAD doesn't use an RSA
KeyPairGeneratorwhen in RSA mode and the ECDSA key type is hardcoded.This change removes the key type specialisation from the constructors of the
AttestationRepositoryandAndroidKeyStoreclasses and moves key type handling into thegenerateKeyPair()method, which already has the key type byte passed as a parameter.AndroidKeyStorenow initialises both ECDSA and RSAKeyPairGeneratorinstances at construction and selects the correct one ingenerateKeyPair()using thekeyStoreKeyTypeparameter.