Skip to content

ci(dry-run): Add dry run build and PR template #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tonywu1999 merged 1 commit into from
Jun 25, 2025
Merged

ci(dry-run): Add dry run build and PR template #89

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions .github/pull_request_template.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
# Motivation and Context

Please include relevant motivation and context of the problem along with a short summary of the solution.

## Changes

Please provide a detailed bullet point list of your changes.

-

## Testing

Please describe any unit tests you added or modified to verify your changes.

## Checklist Before Requesting a Review
- [ ] I have read the MSstats [contributing guidelines](https://github.com/Vitek-Lab/MSstatsConvert/blob/master/.github/CONTRIBUTING.md)
Copy link

@coderabbitai coderabbitai bot Jun 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

Update link to project-local contributing guide

The link points to MSstatsConvert, not MSstatsTMT.

-I have read the MSstats [contributing guidelines](https://github.com/Vitek-Lab/MSstatsConvert/blob/master/.github/CONTRIBUTING.md)
+I have read the MSstatsTMT [contributing guidelines](https://github.com/Vitek-Lab/MSstatsTMT/blob/master/.github/CONTRIBUTING.md)
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
- [ ] I have read the MSstats [contributing guidelines](https://github.com/Vitek-Lab/MSstatsConvert/blob/master/.github/CONTRIBUTING.md)
- [ ] I have read the MSstatsTMT [contributing guidelines](https://github.com/Vitek-Lab/MSstatsTMT/blob/master/.github/CONTRIBUTING.md)
🤖 Prompt for AI Agents 
In .github/pull_request_template.md at line 16, the link to the contributing
guidelines incorrectly points to the MSstatsConvert repository. Update the URL
to point to the MSstatsTMT project's local contributing guide to ensure it
directs users to the correct documentation.

- [ ] My changes generate no new warnings
- [ ] Any dependent changes have been merged and published in downstream modules
- [ ] I have run the devtools::document() command after my changes and committed the added files
18 changes: 18 additions & 0 deletions .github/workflows/dry-run-build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
name: Dry runs for PRs
on:
pull_request:
branches: [devel]
jobs:
build:
runs-on: ubuntu-latest
steps:
- name: Checkout repository
uses: actions/checkout@v4
- name: Setup R and Bioconductor
uses: grimbough/bioc-actions/setup-bioc@v1
with:
bioc-version: devel
- name: Install dependencies
uses: r-lib/actions/setup-r-dependencies@v2
- name: Build, Install, Check
uses: grimbough/bioc-actions/build-install-check@v1
Comment on lines +9 to +18
Copy link

@coderabbitai coderabbitai bot Jun 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

Pin action revisions for supply-chain safety

Tag references (actions/checkout@v4, setup-bioc@v1, etc.) can be overwritten upstream.
For immutable builds, pin each action to a commit SHA:

-uses: actions/checkout@v4
+uses: actions/checkout@v4 # 4d5d7b9f9e63e7f0d…

Do the same for the other three actions.

🧰 Tools
🪛 YAMLlint (1.37.1)

[error] 18-18: no new line character at the end of file

(new-line-at-end-of-file)

🤖 Prompt for AI Agents 
In .github/workflows/dry-run-build.yml between lines 9 and 18, the GitHub
Actions use tag references for actions which can be overwritten upstream,
risking supply-chain security. To fix this, replace each action tag reference
with a pinned commit SHA by appending the specific commit hash after the tag,
for example, change "actions/checkout@v4" to "actions/checkout@v4 #
<commit-sha>". Do this for all four actions to ensure immutable builds.

1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,3 +5,4 @@
*.log
./*.txt
*.Rproj
*.DS_Store