Fixed bug with getValue() failing when in sourceview#298
Open
leonardteo wants to merge 1 commit intoVoog:masterfrom
Open
Fixed bug with getValue() failing when in sourceview#298leonardteo wants to merge 1 commit intoVoog:masterfrom
leonardteo wants to merge 1 commit intoVoog:masterfrom
Conversation
Contributor
|
It fixes the outcome of the error , but not the error itself. From my point of view the toolbar component directly assigning editor.currentView object to string ("source") is not expected or valid thing to do for starters. It would be better if editor.currentView should actually be pointed to the wysihtml5.views.Textarea as the view in return should have a getValue method (textarea has). (like it is done here: https://github.com/Voog/wysihtml/blob/master/src/editor.js#L111) Otherwise opening the html view allows bypassing the parser rules (user can save not allowed html to server and upon reloading editor later it starts clearing code unexpectedly too) It requires rebuilding the toolbar component though |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the bug where
editor.getValue()fails when the editor is in source view (contenteditable mode).