Fix for handleDomNodeRemoved not being called when parent containers removed from DOM#354
Open
Phoebe-G wants to merge 2 commits intoVoog:masterfrom
Open
Fix for handleDomNodeRemoved not being called when parent containers removed from DOM#354Phoebe-G wants to merge 2 commits intoVoog:masterfrom
Phoebe-G wants to merge 2 commits intoVoog:masterfrom
Conversation
…detect more instances where the editor or its target element are removed from the DOM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WYSIHTML editors created on textareas inside jconfirm dialog boxes were not being properly destroyed when the dialog is closed.
The scenario can be recreated quite easily in the simple example (http://voog.github.io/wysihtml/examples/simple.html) by deleting the form element rather than its child elements.
Browser stacktrace after destroying the dialog/container was: