draft(scoped-query): PR review test#20
draft(scoped-query): PR review test#20piggggggggy wants to merge 7 commits intoWANZARGEN:developfrom
Conversation
…ss control Signed-off-by: piggggggggy <samuel.park@mz.co.kr>
Signed-off-by: piggggggggy <samuel.park@mz.co.kr>
Signed-off-by: piggggggggy <samuel.park@mz.co.kr>
Signed-off-by: piggggggggy <samuel.park@mz.co.kr>
Signed-off-by: piggggggggy <samuel.park@mz.co.kr>
Signed-off-by: piggggggggy <samuel.park@mz.co.kr>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Walkthrough이 PR은 기존의 Changes
Sequence Diagram(s)sequenceDiagram
participant C as Component
participant S as useScopedQuery
participant U as UserStore/AppContext
participant Q as VueQuery (useQuery)
C->>S: useScopedQuery(options, requiredScopes) 호출
S->>U: 현재 사용자 스코프 및 앱 준비 상태 확인
S->>S: 스코프 유효성 및 enabled 상태 계산
S->>Q: 조건 만족 시 useQuery 실행
Q-->>S: 쿼리 결과 반환
S-->>C: 최종 결과 반환
Poem
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (10)
apps/web/src/query/composables/use-scoped-query.ts (2)
42-46: import 순서 관련 ESLint 경고 확인
@/store/app-context/app-context-store및@/store/user/user-store의 import가@/api-clients/identity/token/schema/type보다 앞서 오도록 재배치하면 lint 오류가 해결됩니다. 사소해 보이지만, 팀 내 규칙에 맞추어 import 순서를 정렬해주세요.🧰 Tools
🪛 ESLint
[error] 45-45:
@/store/app-context/app-context-storeimport should occur before import of@/api-clients/identity/token/schema/type(import/order)
[error] 45-45: Missing file extension for "@/store/app-context/app-context-store"
(import/extensions)
[error] 46-46:
@/store/user/user-storeimport should occur before import of@/api-clients/identity/token/schema/type(import/order)
[error] 46-46: Missing file extension for "@/store/user/user-store"
(import/extensions)
79-88: 스코프 검증 로그 로직 주의
개발 환경에서만_warnInvalidScopeOnce를 통해 잘못된 스코프 문제를 한 번만 경고하는 방식은, 중복 로그를 줄여서 개발 편의성을 높입니다. 다만 프로덕션 환경에서 유사한 문제가 발생할 경우, 추가 로깅 혹은 에러 처리가 필요한지 고려해 보시기 바랍니다.apps/web/src/services/dashboards/composables/use-dashboard-search-query.ts (1)
18-18:useScopedQueryimport 경로 변경
@/api-clients/_common/composables/use-scoped-query→@/query/composables/use-scoped-query로 바뀌어 코드 구조가 명확해졌습니다. 또한 ESLint가 “Missing file extension”을 보고하므로 필요 시use-scoped-query.ts확장자를 명시해 팀 규칙에 맞춰주세요.🧰 Tools
🪛 ESLint
[error] 18-18: Missing file extension for "@/query/composables/use-scoped-query"
(import/extensions)
apps/web/src/common/modules/widgets/_composables/use-widget-data-table-list-query.ts (1)
10-10: ESLint 경고: 파일 확장자 추가 필요
현재useScopedQuery를 import 할 때 파일 확장자가 누락되어 ESLint 오류가 발생합니다. 프로젝트의 ESLint 설정에 따라 명시적으로.ts확장자를 사용하도록 수정하는 것을 권장합니다.-import { useScopedQuery } from '@/query/composables/use-scoped-query'; +import { useScopedQuery } from '@/query/composables/use-scoped-query.ts';🧰 Tools
🪛 ESLint
[error] 10-10: Missing file extension for "@/query/composables/use-scoped-query"
(import/extensions)
apps/web/src/services/project/v2/components/ProjectDetailTab.vue (1)
11-11: ESLint 경고: 파일 확장자 추가 필요
현재@/query/composables/use-scoped-query의 import 구문에서 파일 확장자가 생략되어 있습니다. 다른 파일들과 동일하게.ts확장자를 명시해 주세요.-import { useScopedQuery } from '@/query/composables/use-scoped-query'; +import { useScopedQuery } from '@/query/composables/use-scoped-query.ts';🧰 Tools
🪛 ESLint
[error] 11-11: Missing file extension for "@/query/composables/use-scoped-query"
(import/extensions)
apps/web/src/common/modules/widgets/_composables/use-widget-query.ts (1)
11-11: ESLint 경고: 파일 확장자 추가 필요
해당 파일에서도useScopedQuery를 import 시 파일 확장자가 누락되었습니다. 프로젝트 표준에 맞추어.ts확장자를 추가할 것을 제안합니다.-import { useScopedQuery } from '@/query/composables/use-scoped-query'; +import { useScopedQuery } from '@/query/composables/use-scoped-query.ts';🧰 Tools
🪛 ESLint
[error] 11-11: Missing file extension for "@/query/composables/use-scoped-query"
(import/extensions)
apps/web/src/services/dashboards/composables/use-dashboard-folder-query.ts (1)
18-18: ESLint 경고: 파일 확장자 추가 필요
현재useScopedQueryimport 시 파일 확장자가 누락되어 있어 ESLint 오류가 발생합니다. 아래와 같이.ts확장자를 추가해 주세요.-import { useScopedQuery } from '@/query/composables/use-scoped-query'; +import { useScopedQuery } from '@/query/composables/use-scoped-query.ts';🧰 Tools
🪛 ESLint
[error] 18-18: Missing file extension for "@/query/composables/use-scoped-query"
(import/extensions)
apps/web/src/services/dashboards/composables/use-dashboard-widget-list-query.ts (1)
15-15: ESLint 경고: 파일 확장자 추가 필요
해당 파일의 import 구문에서도useScopedQuery에 파일 확장자가 누락되어 있습니다..ts확장자를 추가하여 ESLint 경고를 해소해 주세요.-import { useScopedQuery } from '@/query/composables/use-scoped-query'; +import { useScopedQuery } from '@/query/composables/use-scoped-query.ts';🧰 Tools
🪛 ESLint
[error] 15-15: Missing file extension for "@/query/composables/use-scoped-query"
(import/extensions)
apps/web/src/query/composables/__tests__/use-scoped-query.test.ts (1)
11-11: import 순서 개선 제안ESLint 규칙에 따라 import 순서를 조정하면 좋겠습니다.
@/store/user/user-store를@/query/composables/use-scoped-query이전에 import하는 것이 권장됩니다.- import { useScopedQuery } from '@/query/composables/use-scoped-query'; - - import { useUserStore } from '@/store/user/user-store'; + import { useUserStore } from '@/store/user/user-store'; + + import { useScopedQuery } from '@/query/composables/use-scoped-query';🧰 Tools
🪛 ESLint
[error] 11-11:
@/store/user/user-storeimport should occur before import of@/query/composables/use-scoped-query(import/order)
[error] 11-11: Missing file extension for "@/store/user/user-store"
(import/extensions)
apps/web/src/services/dashboards/composables/use-dashboard-query.ts (1)
17-17: import 순서 개선 제안ESLint 규칙에 따라 import 순서를 조정하면 좋겠습니다. store 관련 import는 API 관련 import 이전에 위치하는 것이 권장됩니다.
- import { usePrivateDashboardApi } from '@/api-clients/dashboard/private-dashboard/composables/use-private-dashboard-api'; - import type { PrivateDashboardModel } from '@/api-clients/dashboard/private-dashboard/schema/model'; - import { usePublicDashboardApi } from '@/api-clients/dashboard/public-dashboard/composables/use-public-dashboard-api'; - import type { PublicDashboardModel } from '@/api-clients/dashboard/public-dashboard/schema/model'; - import { useScopedQuery } from '@/query/composables/use-scoped-query'; - import { useServiceQueryKey } from '@/query/query-key/use-service-query-key'; - - import { useAppContextStore } from '@/store/app-context/app-context-store'; + import { useAppContextStore } from '@/store/app-context/app-context-store'; + + import { usePrivateDashboardApi } from '@/api-clients/dashboard/private-dashboard/composables/use-private-dashboard-api'; + import type { PrivateDashboardModel } from '@/api-clients/dashboard/private-dashboard/schema/model'; + import { usePublicDashboardApi } from '@/api-clients/dashboard/public-dashboard/composables/use-public-dashboard-api'; + import type { PublicDashboardModel } from '@/api-clients/dashboard/public-dashboard/schema/model'; + import { useScopedQuery } from '@/query/composables/use-scoped-query'; + import { useServiceQueryKey } from '@/query/query-key/use-service-query-key';🧰 Tools
🪛 ESLint
[error] 17-17:
@/store/app-context/app-context-storeimport should occur before import of@/api-clients/dashboard/private-dashboard/composables/use-private-dashboard-api(import/order)
[error] 17-17: Missing file extension for "@/store/app-context/app-context-store"
(import/extensions)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (13)
apps/web/src/api-clients/_common/composables/use-scoped-query.ts(0 hunks)apps/web/src/common/modules/widgets/_composables/use-widget-data-table-list-query.ts(1 hunks)apps/web/src/common/modules/widgets/_composables/use-widget-data-table-query.ts(1 hunks)apps/web/src/common/modules/widgets/_composables/use-widget-query.ts(1 hunks)apps/web/src/query/composables/__tests__/use-scoped-query.test.ts(1 hunks)apps/web/src/query/composables/use-scoped-query.ts(1 hunks)apps/web/src/query/query-key/_types/query-key-type.ts(1 hunks)apps/web/src/services/dashboards/composables/use-dashboard-folder-query.ts(1 hunks)apps/web/src/services/dashboards/composables/use-dashboard-get-query.ts(1 hunks)apps/web/src/services/dashboards/composables/use-dashboard-query.ts(3 hunks)apps/web/src/services/dashboards/composables/use-dashboard-search-query.ts(1 hunks)apps/web/src/services/dashboards/composables/use-dashboard-widget-list-query.ts(1 hunks)apps/web/src/services/project/v2/components/ProjectDetailTab.vue(1 hunks)
💤 Files with no reviewable changes (1)
- apps/web/src/api-clients/_common/composables/use-scoped-query.ts
🧰 Additional context used
🧬 Code Definitions (3)
apps/web/src/query/composables/__tests__/use-scoped-query.test.ts (2)
apps/web/src/query/composables/use-scoped-query.ts (1)
useScopedQuery(52-93)apps/web/src/store/user/user-store.ts (1)
useUserStore(118-402)
apps/web/src/services/dashboards/composables/use-dashboard-query.ts (1)
apps/web/src/query/composables/use-scoped-query.ts (1)
useScopedQuery(52-93)
apps/web/src/query/composables/use-scoped-query.ts (2)
apps/web/src/store/user/user-store.ts (1)
useUserStore(118-402)apps/web/src/query/query-key/_types/query-key-type.ts (1)
QueryKeyArray(4-4)
🪛 ESLint
apps/web/src/services/dashboards/composables/use-dashboard-get-query.ts
[error] 15-15: Missing file extension for "@/query/composables/use-scoped-query"
(import/extensions)
apps/web/src/common/modules/widgets/_composables/use-widget-data-table-list-query.ts
[error] 10-10: Missing file extension for "@/query/composables/use-scoped-query"
(import/extensions)
apps/web/src/services/dashboards/composables/use-dashboard-folder-query.ts
[error] 18-18: Missing file extension for "@/query/composables/use-scoped-query"
(import/extensions)
apps/web/src/common/modules/widgets/_composables/use-widget-data-table-query.ts
[error] 7-7: Missing file extension for "@/query/composables/use-scoped-query"
(import/extensions)
apps/web/src/services/project/v2/components/ProjectDetailTab.vue
[error] 11-11: Missing file extension for "@/query/composables/use-scoped-query"
(import/extensions)
apps/web/src/common/modules/widgets/_composables/use-widget-query.ts
[error] 11-11: Missing file extension for "@/query/composables/use-scoped-query"
(import/extensions)
apps/web/src/query/composables/__tests__/use-scoped-query.test.ts
[error] 9-9: Missing file extension for "@/query/composables/use-scoped-query"
(import/extensions)
[error] 11-11: @/store/user/user-store import should occur before import of @/query/composables/use-scoped-query
(import/order)
[error] 11-11: Missing file extension for "@/store/user/user-store"
(import/extensions)
apps/web/src/services/dashboards/composables/use-dashboard-search-query.ts
[error] 18-18: Missing file extension for "@/query/composables/use-scoped-query"
(import/extensions)
apps/web/src/services/dashboards/composables/use-dashboard-query.ts
[error] 14-14: Missing file extension for "@/query/composables/use-scoped-query"
(import/extensions)
[error] 15-15: Missing file extension for "@/query/query-key/use-service-query-key"
(import/extensions)
[error] 17-17: @/store/app-context/app-context-store import should occur before import of @/api-clients/dashboard/private-dashboard/composables/use-private-dashboard-api
(import/order)
[error] 17-17: Missing file extension for "@/store/app-context/app-context-store"
(import/extensions)
apps/web/src/query/composables/use-scoped-query.ts
[error] 45-45: @/store/app-context/app-context-store import should occur before import of @/api-clients/identity/token/schema/type
(import/order)
[error] 45-45: Missing file extension for "@/store/app-context/app-context-store"
(import/extensions)
[error] 46-46: @/store/user/user-store import should occur before import of @/api-clients/identity/token/schema/type
(import/order)
[error] 46-46: Missing file extension for "@/store/user/user-store"
(import/extensions)
apps/web/src/services/dashboards/composables/use-dashboard-widget-list-query.ts
[error] 15-15: Missing file extension for "@/query/composables/use-scoped-query"
(import/extensions)
🔇 Additional comments (9)
apps/web/src/query/composables/use-scoped-query.ts (3)
49-55:requiredScopes인자 필수화로 인한 안전성 향상
requiredScopes를[GrantScope, ...GrantScope[]]형태로 강화하면서 최소 하나 이상의 scope가 강제되도록 한 점이 인상적입니다. 잘못된 스코프 설정을 사전에 방지할 수 있어 안전성이 높아졌습니다.
72-76: 동적 enabled 계산 로직 검토
rawEnabled가 없을 경우 기본값을true로 간주하고,isValidScope및isAppReady조건을 결합해 효율적으로 enabled를 계산하고 있습니다. 이로써 컴포넌트 상태, 스코프, 앱 준비 상태 등을 종합적으로 고려해 쿼리가 실행되는 점이 유용해 보입니다.
98-105:_warnMissingRequiredScopes함수 활용성
개발 단계에서requiredScopes가 누락되었거나 비어 있는 경우 경고를 발생시켜 사전 검증이 가능해졌습니다. 프로덕션 단계에는 영향이 없으므로 배포 안정성도 유지됩니다.apps/web/src/query/query-key/_types/query-key-type.ts (1)
4-4: 불변 배열로 변경한 타입
QueryKeyArray를readonly unknown[]로 변경함으로써 쿼리 키에 대한 불변성을 보장하여, 의도치 않은 수정이나 사이드 이펙트를 방지할 수 있습니다.apps/web/src/services/dashboards/composables/use-dashboard-get-query.ts (1)
15-15: import 경로가 업데이트되었습니다.
useScopedQuery의 import 경로가 변경되었습니다. 이제@/query/composables/use-scoped-query에서 가져오고 있습니다. 이 변경은 코드베이스 구조 개선을 위한 것으로 보입니다.🧰 Tools
🪛 ESLint
[error] 15-15: Missing file extension for "@/query/composables/use-scoped-query"
(import/extensions)
apps/web/src/common/modules/widgets/_composables/use-widget-data-table-query.ts (1)
7-7: import 경로가 업데이트되었습니다.
useScopedQuery의 import 경로가 변경되었습니다. 이제@/query/composables/use-scoped-query에서 가져오고 있습니다. 이 변경은 코드베이스 구조 개선을 위한 것으로 보입니다.🧰 Tools
🪛 ESLint
[error] 7-7: Missing file extension for "@/query/composables/use-scoped-query"
(import/extensions)
apps/web/src/query/composables/__tests__/use-scoped-query.test.ts (1)
1-75: useScopedQuery 테스트 파일이 잘 구현되었습니다.
useScopedQuery함수에 대한 테스트 케이스가 잘 작성되었습니다. 사용자 범위(scope)에 따라 쿼리가 적절히 활성화/비활성화되는지 검증하고 있습니다. 모킹(mocking)도 잘 이루어져 있어 테스트의 격리성이 확보됩니다.🧰 Tools
🪛 ESLint
[error] 9-9: Missing file extension for "@/query/composables/use-scoped-query"
(import/extensions)
[error] 11-11:
@/store/user/user-storeimport should occur before import of@/query/composables/use-scoped-query(import/order)
[error] 11-11: Missing file extension for "@/store/user/user-store"
(import/extensions)
apps/web/src/services/dashboards/composables/use-dashboard-query.ts (2)
14-14: import 경로가 업데이트되었습니다.
useScopedQuery의 import 경로가 변경되었습니다. 이제@/query/composables/use-scoped-query에서 가져오고 있습니다. 이 변경은 코드베이스 구조 개선을 위한 것으로 보입니다.🧰 Tools
🪛 ESLint
[error] 14-14: Missing file extension for "@/query/composables/use-scoped-query"
(import/extensions)
70-87: 타입 매개변수가 제거되었습니다.
useScopedQuery호출에서 타입 매개변수가 제거되었습니다. 새로 구현된useScopedQuery함수는 타입 추론을 통해 타입을 자동으로 처리하므로 명시적인 타입 매개변수가 필요 없어졌습니다. 이는 코드를 더 간결하게 만들고 유지보수성을 향상시킵니다.
|
Caution No docstrings were generated. |
Signed-off-by: piggggggggy <samuel.park@mz.co.kr>
2 participants
Skip Review (optional)
style,chore,ci,test,docs)Description (optional)
Things to Talk About (optional)
Summary by CodeRabbit