-
Notifications
You must be signed in to change notification settings - Fork 63
fix: add missing images #830
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
📝 WalkthroughWalkthroughThis PR invalidates a hash for a specific item in the image cache and reorganizes the build script to update the cache only after successful image processing, rather than before processing begins. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related PRs
Suggested labels
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
📜 Recent review detailsConfiguration used: defaults Review profile: CHILL Plan: Pro ⛔ Files ignored due to path filters (219)
📒 Files selected for processing (2)
🧰 Additional context used🧠 Learnings (1)📓 Common learnings⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
🔇 Additional comments (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
It seems there's a bunch of images missing i'm building it now, up to 168 |
|
There's more problems with the images than i thought, there might need one or two prs to fix related issues. |
4863f7a to
b91ea24
Compare
|
This draft is still in design phase, so no need for the code be compliant with lint or to be well designed. Remember this is basically me testing around on what we can do about the problem. I could very much discard all changes. |
b91ea24 to
feb0126
Compare
|
I'll just add the images that are missing first and then we'll think about what to do with the other issues. |
|
🎉 This PR is included in version 1.1272.90 🎉 The release is available on: Your semantic-release bot 📦🚀 |
What did you fix?
Add missing images
Considerations
For some reason when building it also update many entries of itemCount and parents in the All.json file. We should probably change the code to check if all the entries in the cache are in fact stored in disk.
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.