fix(spec): move specification to root dir, symlink to public #633
Conversation
✅ Deploy Preview for webmonetization-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
sidvishnoi
force-pushed
the
spec-build-fixup
branch
from
2bcfc7c to
a3498a1
Compare
sidvishnoi
force-pushed
the
spec-build-fixup
branch
from
a3498a1 to
7b7ba03
Compare
public/specification
Outdated
There was a problem hiding this comment.
@JoblersTune Please check this continues to work on Windows. I've tested on MacOS and Linux.
There was a problem hiding this comment.
Unfortunately I don't have a Windows machine either.
There was a problem hiding this comment.
Maybe one of the tech writers can help, if I remember one of them had a Windows machine, maybe @brad-dow ?
There was a problem hiding this comment.
@DarianM Can you check the follow work ok:
pnpm startpnpm build; pnpm preview
There was a problem hiding this comment.
😭 Can you check on /specification/ as well (note: trailing slash)?
There was a problem hiding this comment.
Trailing slash has the same behavior
There was a problem hiding this comment.
/specification preview works fine, there's a /specification 404 dev problem for windows. bun build && bun preview are also fine; using pnpm fine too
Move specs to root dir, making it easier to discover and update, separate from Astro structure.
Symlink it to public/specification (at build time for platform compatibility), so Astro copies the specifications as is without any processing (including all the includes), so ReSpec documents continue to work.
cc: @lukewarlow @asurkov
Before:
After: