Change $userrequest source in redirect()#5
Open
MrAlexWeber wants to merge 1 commit intoWPDevelopers:masterfrom
Open
Change $userrequest source in redirect()#5MrAlexWeber wants to merge 1 commit intoWPDevelopers:masterfrom
MrAlexWeber wants to merge 1 commit intoWPDevelopers:masterfrom
Conversation
While testing a site that uses a mixed HTTP/HTTPS setup, I ran into an issue here related to the get_protocol() function. It seems to me that neither get_protocol() nor get_address() are necessary, as PHP provides $_SERVER['REQUEST_URI'], which has already the name of the requested page without hostname or protocol. Please consider merging this change to further simplify this awesome plugin and add support for even more sites (e.g. those with multiple server aliases, etc.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While testing a site that uses a mixed HTTP/HTTPS setup, I ran into an issue here related to the get_protocol() function. It seems to me that neither get_protocol() nor get_address() are necessary, as PHP provides $_SERVER['REQUEST_URI'], which has already the name of the requested page without hostname or protocol. Please consider merging this change to further simplify this awesome plugin and add support for even more sites (e.g. those with multiple server aliases, etc.)