resource deletion from kb #672
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
/windsurf-review |
ViaSocket-Git
force-pushed
the
KB_resource_deletion
branch
2 times, most recently
from
5ae7f17 to
a58812e
Compare
Collaborator
Author
|
/windsurf-review |
![windsurf-bot[bot]](https://avatars.githubusercontent.com/in/1066231?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Other comments (3)
- src/db_services/agentVersion.service.js (570-587) This function modifies documents but doesn't invalidate related cache entries. Other functions in this file (like `updateAgents` and `deleteAgentVersion`) use `_buildCacheKeys` and `deleteInCache` to maintain cache consistency. Consider adding cache invalidation to prevent stale data.
- src/controllers/rag.controller.js (405-408) While logging cleanup errors is good, consider implementing a more robust error handling strategy for the resource reference cleanup. Orphaned references could cause issues later. You might want to add a background job or retry mechanism for failed cleanups.
- src/db_services/agentVersion.service.js (570-570) This function lacks JSDoc documentation explaining its purpose, parameters, and return value. Consider adding documentation to maintain consistency with the codebase and improve maintainability.
💡 To request another review, post a new comment with "/windsurf-review".
| }); | ||
|
|
||
| // If external deletion was successful | ||
| if (response.status === 200) { |
Contributor
There was a problem hiding this comment.
The status check response.status === 200 might be too restrictive. Consider using response.status >= 200 && response.status < 300 to handle all successful HTTP responses, as some APIs might return 204 No Content for successful deletions.
ViaSocket-Git
force-pushed
the
KB_resource_deletion
branch
from
a58812e to
95e85dc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resource is now being deleted