Skip to content

Conversation

@MadDERt
Copy link
Contributor

@MadDERt MadDERt commented Dec 3, 2025

  • Mainly implemented by mimicking the existing script signal.R.
  • Patients experiencing any event within the event set are flagged as target patients.

@ShixiangWang
Copy link
Contributor

@MadDERt 没看下为什么 check 没过么?

@MadDERt
Copy link
Contributor Author

MadDERt commented Dec 18, 2025

@ShixiangWang 老师,之前的R-CMD_check的错误修复了,现在R-CMD-check-bioc新出现的错误是由另外的脚本引发的,这种情况下我是在原来的PR上进行修改,还是另外新建分支修改比较合适呢?

@ShixiangWang
Copy link
Contributor

@MadDERt 你应该用不同的分支完成不同的事情,新的事情新建一个分支再提交pr,这样才比较能够有效协作。目前的错误,尽量在本身你的test进行修复,并且补充新增内容的说明。

@ShixiangWang ShixiangWang merged commit a63eb58 into WangLabCSU:devel Dec 23, 2025
7 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants