[docs, misc] chore: finalize AGENTS guidelines and ignore local planning files#62
[docs, misc] chore: finalize AGENTS guidelines and ignore local planning files#62Wangmerlyn merged 3 commits intomainfrom
Conversation
Summary of ChangesHello @Wangmerlyn, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a foundational document outlining best practices and operational guidelines for coding agents, ensuring consistency and quality across development efforts. Concurrently, it refines the repository's Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
📝 WalkthroughWalkthroughAdds three mkdocs-related ignore entries to Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
No actionable comments were generated in the recent review. 🎉 🧹 Recent nitpick comments
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Code Review
This pull request introduces a comprehensive AGENTS.md file with guidelines for automated agents and updates the .gitignore to exclude local planning files. The guidelines are well-structured and clear, providing valuable direction for development in this repository. I've added one comment to address a potentially outdated file path in the testing documentation to ensure its accuracy.
AGENTS.md
Outdated
|
|
||
| - Before pushing, run targeted tests relevant to changed modules first, then broader checks. | ||
| - Common targeted commands: | ||
| - `pytest tests/cuda_controller tests/global_controller tests/utilities/test_platform_manager.py tests/test_cli_thresholds.py` |
There was a problem hiding this comment.
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@AGENTS.md`:
- Around line 33-36: The root-docs rule is ambiguous because AGENTS.md is a
project-specific file in the repo root; update the wording in AGENTS.md (the
bullet about "Do NOT place project-specific documentation in the root
directory") to either add an explicit exception for existing top-level files
like AGENTS.md/README or rephrase to “Avoid placing new project-specific
documentation in the root; keep only canonical top-level docs (e.g., AGENTS.md,
README) in root.” This change should be applied in the same AGENTS.md paragraph
so reviewers clearly understand the exception without altering other rules.
Summary by CodeRabbit