Skip to content

Conversation

@yombodev
Copy link
Contributor

@yombodev yombodev commented Jan 6, 2026

No description provided.

@Torwent
Copy link
Collaborator

Torwent commented Jan 7, 2026

Hi!

I can't accept this as is. It will break itemfinder for some items.

Items render in a 36 by 32 pixels box, if you change that box, for whatever reason, e.g. because the click box is smaller which is common, it will only work for items that fit neatly inside of the new box you created, everything else will not work.

Even if the "slot" box is just 31x31, items will render out of it.

For example, Inventory slots are 32x32 and large stacks of zulrah scales will render outside of it and also multiple seeds.

If you did this because this is supposed to be the click box you have 2 options:

  • add a separate box for the clickbox, feel free to rename this to something better if you do that
  • in TRSGrandExchangeSlot.Contains and TRSGrandExchangeSlot.Discover expand the clickbox so the final box being checked is 36 by 32, like TRSItemInterface does with it's DiscoverOffset

@Torwent
Copy link
Collaborator

Torwent commented Jan 7, 2026

Also, OCR.RecognizeLines I already kinda fixed. I just did something quick that worked but I prefer your code as it's simpler.
Anyway, I already fixed the issue in Simba and I'm just waiting for Olly to accept it or just write his own solution as he didn't quite like mine. But yeah, the issue is in Simba and that's really where it should be fixed

@yombodev
Copy link
Contributor Author

yombodev commented Jan 8, 2026 via email

@Torwent
Copy link
Collaborator

Torwent commented Jan 8, 2026

LLevo 8 años viviendo en España, hablo español perfectamente :)
Pero no te preocupes, te he entendido perfectamente.

Esta tarde le echo un ojo y lo arreglo si me da tiempo

@Torwent
Copy link
Collaborator

Torwent commented Jan 8, 2026

Ya esta arreglado

@Torwent Torwent closed this Jan 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants