Fix stack buffer overflow in AES-CBC test#8
Open
fishilico wants to merge 1 commit intoWaterJuice:masterfrom
Open
Fix stack buffer overflow in AES-CBC test#8fishilico wants to merge 1 commit intoWaterJuice:masterfrom
fishilico wants to merge 1 commit intoWaterJuice:masterfrom
Conversation
On x86-64, the AES-CBC test fails because the `vector` local buffer is to small to hold the encrypted test vector: the vector was created with 64 bytes while the buffer can only hold 48. Increase `TEST_VECTOR_OUTPUT_SIZE` to 64 to fix this issue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
While testing Pull Request #7,
projects/WjCryptLibTest/WjCryptLibTestwas failing. Investing why led me to discovering a problem with the size of a stack buffer in the code which tests AES-CBC.On x86-64, the AES-CBC test fails because the
vectorlocal buffer is to small to hold the encrypted test vector: the vector was created with 64 bytes while the buffer can only hold 48.This Pull Requests increases
TEST_VECTOR_OUTPUT_SIZEto 64 to fix this issue.