Fixed issue where errorHandler in BsonInputFormatter is invoked multitple times#213
Open
pluma9 wants to merge 1 commit intoWebApiContrib:masterfrom
Open
Fixed issue where errorHandler in BsonInputFormatter is invoked multitple times#213pluma9 wants to merge 1 commit intoWebApiContrib:masterfrom
pluma9 wants to merge 1 commit intoWebApiContrib:masterfrom
Conversation
…voked multitple times
pluma9
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CreateJsonSerializer()may return a serializer that was previously returned to the pool. This means this serializer'sErrorevent already have a subscriber. If we try to add more subscribers (jsonSerializer.Error += errorHandler;), theerrorHandlerwill be invoked multiple times when the serializer fail toDeserialize. Therefore, we need to remove the subscriber before returning the serializer to the pool.