Adding type hints for other End files delegating.py, grouping.py, ipexing.py, notifying.py, exchanging.py #355
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uping.py, ipexing.py, notifying.py, exchanging.py
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #355 +/- ##
=======================================
Coverage 97.53% 97.53%
=======================================
Files 1 1
Lines 324 324
Branches 24 24
=======================================
Hits 316 316
Misses 8 8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
iFergal
reviewed
Dec 10, 2025
| sigs: string[], | ||
| recp: string[] | ||
| ): Promise<any> { | ||
| ): Promise<Operation<unknown>> { |
Collaborator
There was a problem hiding this comment.
@lenkan We have a follow up PR (in progress, almost there) that converts these to specific WitnessOperation, GroupOperation etc... (not generics) so should cleanup some of the things from this PR.
|
|
||
| assert.strictEqual(offer.exn.p, applySaid); | ||
| assert( | ||
| 'e' in offer.exn && |
Collaborator
There was a problem hiding this comment.
@lenkan Hmm, I feel like this will become annoying. We could just use any instead of unknown in these scenarios, or alternatively offer a bunch of type guard functions but that list could grow quite large and hard to maintain. Thoughts?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.