[Actions][Linux] Add more plugins to be built, fix all compile warnings and errors#371
Merged
VeithMetro merged 6 commits intomasterfrom Dec 11, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes compilation warnings and errors for Linux builds by updating several plugin files. The changes primarily focus on marking unused parameters and updating function signatures to match interface requirements.
- Mark unused function parameters with
VARIABLE_IS_NOT_USEDmacro or comment syntax to suppress compiler warnings - Update
SubscribeandUnsubscribemethod signatures to include a newindexparameter - Adjust warning macro formatting (PUSH_WARNING/POP_WARNING) by removing trailing semicolons
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| RustBridge/RustBridge.h | Updated PUSH_WARNING and POP_WARNING macro formatting to remove trailing semicolons |
| RustBridge/RustBridge.cpp | Marked unused parameters in Deinitialize, Detach, and RustInvoke methods; fixed "parmeters" typo to "parameters" |
| BridgeLink/BridgeLink.h | Added index parameter to Subscribe/Unsubscribe methods and marked unused plugin parameters in lifecycle methods (Destroy, Activated, Deactivated, Unavailable) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
sebaszm
approved these changes
Dec 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.