Adjust all places where RPC::IteratorType is created to use std::vector#372
Open
VeithMetro wants to merge 3 commits intomasterfrom
Open
Adjust all places where RPC::IteratorType is created to use std::vector#372VeithMetro wants to merge 3 commits intomasterfrom
VeithMetro wants to merge 3 commits intomasterfrom
Conversation
sebaszm
requested changes
Dec 14, 2025
Contributor
sebaszm
left a comment
sebaszm
left a comment
There was a problem hiding this comment.
In some cases we have an idea how much elements will be pushed to the vector, so I suppose reserve() would be beneficial?
sebaszm
approved these changes
Dec 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.