Separates variables to variables.less file to allow overwriting#15
Open
filecage wants to merge 4 commits intoWhatsNewSaes:masterfrom
Open
Separates variables to variables.less file to allow overwriting#15filecage wants to merge 4 commits intoWhatsNewSaes:masterfrom
filecage wants to merge 4 commits intoWhatsNewSaes:masterfrom
Conversation
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I stumbled upon this quite often now, been using skeleton-less in many projects. It's the same issue every time: I am unable to modify Skeleton's variables because they are packed in the skeleton.less.
My previous approach was to add the skeleton.less to my application repository rather than requiring it as dependency and modifying the file. For my latest project, I am using webpack with react and with a different approach of source file distribution, it is necessary to define skeleton as a remote dependency. I have created this PR to allow modifying the variables anyway.
Backwards compatibility is kept, importing skeleton.less will result in a complete skeleton-package, including variables and main rules.
This PR refers to issue #13, but does not resolve it.
We might discuss the filenames - while default-variables.less makes it pretty clear, it looks ugly to me. variables.less could be a bit... eye-friendlier. :)