Skip to content

Conversation

@Seojegyeong
Copy link
Collaborator

🚨 관련 이슈

#30

✨ 변경사항

  • 🐞 BugFix Something isn't working
  • 💻 CrossBrowsing Browser compatibility
  • 🌏 Deploy Deploy
  • 🎨 Design Markup & styling
  • 📃 Docs Documentation writing and editing (README.md, etc.)
  • ✨ Feature Feature
  • 🔨 Refactor Code refactoring
  • ⚙️ Setting Development environment setup
  • ✅ Test Test related (storybook, jest, etc.)

✏️ 작업 내용

  • 로그인 API 연동

😅 미완성 작업

N/A

📢 논의 사항 및 참고 사항

N/A

💬 리뷰어 가이드 (P-Rules)
P1: 필수 반영 (Critical) - 버그 가능성, 컨벤션 위반. 해결 전 머지 불가.
P2: 적극 권장 (Recommended) - 더 나은 대안 제시. 가급적 반영 권장.
P3: 제안 (Suggestion) - 아이디어 공유. 반영 여부는 드라이버 자율.
P4: 단순 확인/칭찬 (Nit) - 사소한 오타, 칭찬 등 피드백.

@Seojegyeong Seojegyeong requested review from YermIm and jjjsun February 4, 2026 00:49
@Seojegyeong Seojegyeong self-assigned this Feb 4, 2026
@Seojegyeong Seojegyeong added the 📬 API 서버 API 통신 label Feb 4, 2026
@Seojegyeong Seojegyeong linked an issue Feb 4, 2026 that may be closed by this pull request
7 tasks
@YermIm
Copy link
Collaborator

YermIm commented Feb 4, 2026

P4: 확인했습니다 수고하셨습니다!!

Copy link
Collaborator

@jjjsun jjjsun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P4: 코드 확인했습니다! 고생하셨어요!

const { accessToken } = response.data;
localStorage.setItem("accessToken", accessToken);
loginAction(data.email);
navigate("/");
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P3: replace: true 사용해서 뒤로가기 막아두는건 어떨까요?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

📬 API 서버 API 통신

Projects

None yet

Development

Successfully merging this pull request may close these issues.

✨ [Feature] 로그인 API 연동

4 participants