Conversation
WhiZTiM
left a comment
WhiZTiM
left a comment
There was a problem hiding this comment.
Thank you for this pull request. I have reviewed and I am ready to merge it just right after we resolve a few items.
-
The documentation fix is awesome, and we are good to go there.
-
Including
<iso646.h>header feels hackish. The alternative tokens such asand,or, etc are defined in the<iso646.h>header as MACROS. This was introduced in C95 (a ISO amendment of C89 standard)... So in "C" mode the header is necessary for the C alternative "keywords".However, in C++, they are keywords. And such header isn't necessary. Albeit, MSVC is notorious for non-standards compliance. MSVC disables the alternative keywords as an extension; To enable it, we require the
/Zacompiler flag. See MSVC Alternative tokens.Evidently, my CMake skills were pretty bad when I wrote the CMake file for this project, I will work on improving it.
.So, does compiling the project with the/Zaflag work for you?
.Or do we just change change all occurences ofandandorto&&and||respectively?
| #include <unordered_map> | ||
| #include <map> | ||
| #include <initializer_list> | ||
| #include <iso646.h> |
There was a problem hiding this comment.
This is probably superfluous, since #include <iso646.h> already included in types.hpp which is included in this file. See line 55
| #include <cstring> | ||
| #include <algorithm> | ||
| #include <iostream> | ||
| #include <iso646.h> |
|
/Za works. Will remove the <iso464.h> from the pull request |
2 participants
No description provided.