Add VSOCK option for X410 setup

[crramirez]

Summary

• allow selecting TCP or VSOCK connection when configuring X410
• cover both connection types with unit tests

Testing

• ./tests/x410.sh
• shellcheck pengwin-setup.d/x410.sh rpm/pengwin-setup.d/x410.sh tests/x410.sh

---

https://chatgpt.com/codex/tasks/task_e_68b849b703188327985009959acde288

[Copilot]

Pull Request Overview

Adds VSOCK connection support for X410 configuration, allowing users to choose between TCP and VSOCK connection types when setting up X410. The change introduces command-line arguments and interactive menu selection for connection type configuration.

• Adds VSOCK and TCP command-line argument parsing for connection type selection
• Implements interactive menu for connection type selection when no arguments provided
• Creates separate configuration files based on selected connection type

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File	Description
pengwin-setup.d/x410.sh	Adds connection type parsing and generates different X410 configurations for TCP vs VSOCK
rpm/pengwin-setup.d/x410.sh	RPM variant with same connection type selection logic and configuration generation
tests/x410.sh	Updates test coverage to verify both TCP and VSOCK connection configurations

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[Copilot]

Inconsistent shebang usage. The VSOCK configuration uses #!/bin/sh while the TCP configuration uses #!/bin/sh as well, but the main script uses bash features. Consider using #!/bin/bash for consistency since the script uses bash-specific features like [[ ]].

[crramirez]

As you can see the script is going into /etc/profile.d for maximum flexibility with zsh, those scripts must be tied to posix shell

[Copilot]

Inconsistent shebang between pengwin-setup.d and rpm versions. The RPM version uses #!/bin/bash for VSOCK while pengwin-setup.d uses #!/bin/sh. These should be consistent across both implementations.