MAINT allow to set environment variable at install#4
Open
glemaitre wants to merge 1 commit intoWho8MyLunch:masterfrom
Open
MAINT allow to set environment variable at install#4glemaitre wants to merge 1 commit intoWho8MyLunch:masterfrom
glemaitre wants to merge 1 commit intoWho8MyLunch:masterfrom
Conversation
Owner
|
@glemaitre I updated the setup.py file to check the system platform type before setting any specific compiler or linker options. This is prefered over setting/reading environment variables. |
Author
|
What would happen if you use mingwin in windows? The flag seems to be for MSCV so I was unsure that checking the os would work under Windows with another compiler than MSCV
|
Owner
|
@glemaitre yikes I cannot believe how difficult this became! I don't know the 'best' way to set these options that also allows for MINGW, and I just spent half my morning unsuccessfully trying to figure it out. For now I've removed the platform-specific compiler arguments. |
Author
|
I thought to pass --install-option="args" when installing with pip. However it is not so much documented and I wanted to have a quick fix for a CI. I don't know what you think about passing option at install?
|
Owner
|
Passing options at pip CLI would be perfect! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is not practical to hard code
flag_MSCVsince that one can need to install the package from pip without editing thesetup.py. In this regard, I did a small hack to read an environment variable to turn ON/OFF the flag for the install.