More tests for the LSP contract #34
Conversation
|
✔️ Deploy Preview for romantic-shirley-1fb5ce ready! 🔨 Explore the source changes: a0bf555 🔍 Inspect the deploy log: https://app.netlify.com/sites/romantic-shirley-1fb5ce/deploys/60d80f6750ad090007c397f1 😎 Browse the preview: https://deploy-preview-34--romantic-shirley-1fb5ce.netlify.app |
…out OptimisticOracle.
| const addresses: Record<string, Address> = { | ||
| const addresses = { | ||
| WETH: "0xd0a1e359811322d97991e03f863a0c30c2cf029c", | ||
| LSPCreator: "0x4C68829DBD07FEbB250B90f5624d4a5C30BBeC2c", |
There was a problem hiding this comment.
Maybe we should use the addresses.json file here. I recently had the problem that the json file contained the outdated LSPCreator address leading to the issue that the redeeming worked in tests but not in the app, which was quite a confusing situation.
| } | ||
| const contracts: Record<string, Contract> = {} | ||
| let namedAccounts: Record<string, Address> | ||
| let contracts: Record<keyof typeof addresses, Contract> |
There was a problem hiding this comment.
I can't run any tests because it complains that contracts is undefined.
I think you will have to initialize the variable here. (See old version)
There was a problem hiding this comment.
Unfortunately after changing that I still get a bunch of errors due to contract objects being undefined. Were you able to run the tests on your machine ? (If so what is the command you used?)
No description provided.