Fuzzy match capture to reference images #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Hey there! Glad you got some use out of this project I'll run this on my system over the weekend, and I'll merge if it works on my 1920x1080 Tentatively, I don't see any issues with this. Thanks for using & contributing 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a really cool project!
I noticed on my setup (Steam, 4K monitor running at non-native 1920x1080, game fullscreened), for no apparent reason the captured image rgb values would occasionally differ by exactly one from the reference images, eg (237, 105, 10) in the capture vs (236, 105, 10) in the reference.
I was able to hack around this by considering the capture a match provided all three values in each rgb triplet were within 1 of the reference image. Once I made this change everything worked as expected.
Feel free to decline this PR as it may just be a peculiarity of my settings; I just wanted to submit a heads-up in case anyone else runs into similar issues.