refactor: rename *Info types to domain-role names#619
Merged
Conversation
Rename generic *Info types to more descriptive domain-role names: - WorktreeInfo → WorktreeState (kild-git) - ProjectInfo → GitProjectState (kild-git) - BranchInfo → BranchState (kild-git) - PrInfo → PullRequest (kild-core forge) - NativeWindowInfo → NativeWindow (kild-core terminal) Pure rename, no behavior changes. Updates all usages across kild-git, kild-core, kild CLI, and documentation. Closes #522
Align test function names with the renamed types: - test_worktree_info → test_worktree_state - test_worktree_info_preserves_original_branch_name → test_worktree_state_preserves_original_branch_name - test_project_info → test_git_project_state - test_branch_info → test_branch_state - test_pr_info_serde_roundtrip → test_pull_request_serde_roundtrip - test_pr_info_with_none_summaries → test_pull_request_with_none_summaries - test_native_window_info_fields → test_native_window_fields
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
WorktreeInfo→WorktreeState,ProjectInfo→GitProjectState,BranchInfo→BranchStatein kild-gitPrInfo→PullRequestin kild-core forge moduleNativeWindowInfo→NativeWindowin kild-core terminal modulePure rename — no behavior changes. Per CLAUDE.md naming contract: "Name types by domain role, not implementation detail."
Test plan
cargo fmt --check— 0 violationscargo clippy --all -- -D warnings— 0 warningscargo test --all— all tests pass (3 pre-existing env-dependent test failures unrelated to this change)cargo build --all— clean buildCloses #522