-
Notifications
You must be signed in to change notification settings - Fork 42
Add certificate automation #617
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add certificate automation #617
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's add some tests for confidence; also, can we move the folder as a sub-folder under "tools"? These are where other automation scripts we use are placed.
Otherwise LGTM🙌
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we write some tests too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
Very important!
| @@ -0,0 +1,3 @@ | |||
| TestFN TestLN | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please move this folder under tools and update README there to include this extra automation. Thanks for the amazing script, I will give a try locally also, to extend and create another type of certificate.
| { | ||
| "certificate_types": [ | ||
| { | ||
| "type": "mentee", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great idea! Looking forward to you merge it and I can extend to new certificates :)
Description
Add certification automation
Change Type
Related Issue
Screenshots
Pull request checklist
Please check if your PR fulfills the following requirements: