-
Notifications
You must be signed in to change notification settings - Fork 31
Draft a contributing page to include testing section #170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Draft a contributing page to include testing section #170
Conversation
|
@stepsen89 , could you also please review the Contribution Guide? Thanks! |
2bff08c to
45c13f4
Compare
|
|
||
| We are really glad you're reading this, because we need volunteer developers and testers to help this project grow. | ||
|
|
||
| If you haven't already, come find us in [Slack](https://bit.ly/WCC-slack-invite), join the Slack channel [#i_want_to_help](https://womencodingcommunity.slack.com/archives/C06VB8BNL86), and say hi :wave: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we really need this one here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@stepsen89, the rationale was to target people who were pointed to the repo directly who may not be aware of the official website or the Slack group.
Would you agree that targeting such people is a good idea? If you do, as an alternative to the Slack links, I can add the Website (maybe https://www.womencodingcommunity.com/about?)
Let me know if you would prefer I remove that block altogether instead.
6beed75 to
92603b3
Compare
92603b3 to
3257147
Compare
|
| name: 'Instagram', | ||
| url: 'https://www.instagram.com/women_coding_community/', | ||
| }, | ||
| // TODO: Review if the link should really be what is there (below): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nora-weisser marking you to know about this TODO - let me know if you prefer me to change the URL (which will fix the test) instead of leaving it like this
| }, | ||
| // TODO: Review if the link should really be what is there (below): | ||
| // https://www.instagram.com/accounts/login/?next=https%3A%2F%2Fwww.instagram.com%2Fwomen_coding_community%2F&is_from_rle | ||
| // { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would take out this change from this PR, because it is not related to contribution docs



Description
Draft a contributing page to include a testing section - basically copying the information on https://www.womencodingcommunity.com/about page
Type
Pull request checklist
Please check if your PR fulfills the following requirements: