test: Navigate to Website logo #191
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Wrong files, raising PR again |
|
|
||
| test('NAV-006 Validate logoclick navigation', async ({ basePage,homePage}) => { | ||
| await basePage.navigateToPath('/'); | ||
| await expect(basePage.logo).toBeVisible(); |
Contributor
There was a problem hiding this comment.
It is unnecessary to verify if the logo is visible, click action is enough. If logo is not present, it will throw an error.
Contributor
Author
There was a problem hiding this comment.
Thanks. Done the suggested changes.
| await basePage.verifyURL('/mentorship/mentors'); | ||
| }); | ||
|
|
||
| test('NAV-006 Validate logoclick navigation', async ({ basePage,homePage}) => { |
Contributor
There was a problem hiding this comment.
Suggested change
| test('NAV-006 Validate logoclick navigation', async ({ basePage,homePage}) => { | |
| test('NAV-006 Validate logo click navigation', async ({ basePage,homePage}) => { |
Contributor
|
@nimat1 , could you please update docs as well? thanks! |
nora-weisser
approved these changes
Dec 26, 2025
Contributor
Author
Done the changes, thanks ! |
Contributor
Author
|
Done the all suggested changes. |
|
nora-weisser
approved these changes
Jan 5, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Type
Related Issue
Screenshots
Testing
Pull request checklist
Please check if your PR fulfills the following requirements: