Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
sirreal
added
the
[Type] Task
|
Size Change: +2.23 kB (+0.13%) Total Size: 1.75 MB
ℹ️ View Unchanged
|
sirreal
force-pushed
the
upgrade/framer-motion
branch
from
f301f48 to
b2ffb94
Compare
youknowriad
approved these changes
May 10, 2024
Contributor
youknowriad
left a comment
youknowriad
left a comment
There was a problem hiding this comment.
I tested all the animations that I can think of in our code and everything seems to be working properly.
sirreal
force-pushed
the
upgrade/framer-motion
branch
from
ab4326f to
c6e8268
Compare
Member
Author
|
There are 3 snapshot failures that are reproducible locally. I would really appreciate help getting this landed if someone can investigate those. |
Contributor
|
For me these snapshots are not very useful and ideally the test should be more specific. That said, adding |
Member
Author
|
I updated the snapshots. |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Upgrade framer-motion package.
This is a significant diff, although I see no release notes to speak of on why it's a major (potentially breaking) version change.
Includes #61532
Extracted from #61486
Why?
This package has type conflicts with recent types, these can manifest causing build issues. motiondivision/motion#2587
How?
Upgrade the package to include the fix.
Testing Instructions
I'm not sure where or how this is used.