Notes: Simplify editing mode change position tracking#73696
Merged
Conversation
Mamaduka
added
[Type] Code Quality
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Member
Author
|
Size Change: -92 B (0%) Total Size: 2.58 MB
ℹ️ View Unchanged
|
t-hamano
approved these changes
Dec 3, 2025
Contributor
t-hamano
left a comment
t-hamano
left a comment
There was a problem hiding this comment.
Nice refactoring! Do we like to backport this PR to 6.9.1?
Member
Author
|
Thanks for testing, @t-hamano! Unless it’s needed to fix merge conflicts, let’s avoid backporting code quality refactorings. Minor releases are for bugfixes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
This is a follow-up to #73046.
PR refactors
useFloatingThreadhook and removes the need for keeping track ofblockMode. This should be a simplified fix for #72836.Why?
Fewer dependencies for effects to worry about is always better.
How?
I basically replaced
useBlockElementRefwithuseBlockElement. The latter reacts to DOM changes and triggers required recalculations.The returned
blockRefvalue from the hook was no longer used, which led me to this refactoring and alternative solution.Testing Instructions
Same as #73046. Confirm that there are no regressions.
Testing Instructions for Keyboard
Same.