Make format control restrictions experimental#74739
Closed
Conversation
|
Size Change: +40 B (0%) Total Size: 3.09 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 885212f. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/21138411750
|
t-hamano
force-pushed
the
restrict-formatting-experimental
branch
from
885212f to
e241f5a
Compare
t-hamano
requested review from
ellatrix,
spacedmonkey and
tellthemachines
as code owners
t-hamano
added
the
Backport to WP Minor Release
Contributor
Author
|
@getdave @Mamaduka @scruffian @talldan @jeryj, I believe this approach is the best to avoid breaking backward compatibility for now. Please let me know your thoughts. |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Contributor
|
I think it's a feature that's too small to warrant an experiment flag. Usually those are for bigger feature. Perhaps it'd be better to stabilize the prop/key if it's causing an issue. I didn't work on it, so I don't know if there are any concerns still to be addressed. If possible, it would also be good to fix that |
Contributor
Author
|
Thanks for the suggestion.
Another idea is to combine "Pattern Editing" and "Format Control Restrictions" and set it like "Content Only Editing Experience": 
I wasn't involved in this feature, but even if it were possible to stabilize it, it would be a "new feature" and therefore would not be backported to 6.9.1. This means users will continue to experience issues until 7.0 is released, although it has not yet been decided whether 6.9.1 will be released. I can think of three options, and I prefer the first or third approach.
|
Contributor
I'm going to try to remove the Pattern Editing flag very soon to stabilize that experiment. |
Contributor
Experiments aren't released in WordPress, they are a gutenberg plugin only feature. Removing the API for 6.9.1 might be the only option if a fix for 6.9.1 is necessary. As long as the user experience is better without it. I think it might be better to focus on a proper fix for 7.0 though. |
Member
This approach makes sense to me ✅ |
Contributor
Author
|
Thanks for the feedback, everyone! It's not yet decided whether 6.9.1 will be released, bit if it is, I'll submit a new PR for the 6.9 branch right away. See this discussion on Slack: https://wordpress.slack.com/archives/C08MVR1MU2K/p1768180055397539 I've also submitted an issue to stabilize this API for 7.0. #74765 |
t-hamano
removed
the
Backport to WP Minor Release
Member
|
Now that we have minor release schedule, it might be worth creating a new PR for the 6.9 branch. |
Contributor
Author
|
#74799 reverts the private API for WP 6.9.1 release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #71058
What?
This PR puts the inline formatting control restriction behind an experimental flag.
Why?
#71058 introduced the
essentialFormatKeywithSymbol()to only allow basic fomats in contentOnly mode. This API is private, so consumers can't mark their own inline formats as "essential". This has led to some users finding this behavior to be a bug, as reported in #74168 and #74345. Personally, I think this API should be developed as an experimental feature until it is stabilized, otherwise it will have a huge impact on consumers.How?
Adds a news
__experimentalRestrictFormattingInContentOnlyModeflag to make this feature experimental.Testing Instructions
Pattern Override
templateLock: contentOnly