Fix 'core/interface' registration error#725
Merged
dd32 merged 1 commit intoWordPress:trunkfrom Jul 17, 2025
Merged
Conversation
ryelle
approved these changes
Jul 8, 2025
Contributor
ryelle
left a comment
There was a problem hiding this comment.
Looks good, fixes the error as described.
The failing test is also failing on trunk, and it's two parts— first, the call to npm run test:unit --workspace=wporg-pattern-directory-theme can be removed, since the old theme is not used anymore. But then the creator tests also fail with "SyntaxError: Unexpected token 'export'". Out of scope for this PR, and maybe irrelevant with #719 since it removes the separate creator plugin.
Collaborator
Author
This was referenced Jul 17, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #723.
This PR fixes the
core/interfaceregistration error, but it doesn't fix the other errors mentioned in the issue.This error happens because
core/interfaceis a package included in the bundle and not available on the document object.Currently, on the
/new-pattern/route are loaded thesite-editorscripts and the bundle of the pattern creator editor.Both of them, under the hood, load the
@wordpress/editorpackage and this causes that thecore/interfacestore is registered twice.With this PR, the
@wordpress/editoris bundled in the pattern creator editor and thesite-editorscripts aren't loaded. In this way, thecore/interfacestore is registered once.At the same time, while this PR can be a good temporary solution, I think that we need to explore #719. As mentioned in #719, this will reduce the maintenance cost and fix other issues too.
Props ,
Screenshots
How to test the changes in this Pull Request:
/new-pattern/Store "core/interface" is already registered.isn't visible.