Open
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Fix missing and broken internationalization (i18n) in the notification emails and user-facing admin notices.
Why?
Several user-facing strings were not translatable:
notify_user_password_reset) were bare English string literals — not wrapped in any translation function. Same for the admin notification email (notify_admin_user_password_reset). This means these strings are completely untranslatable regardless of the site's locale.esc_html__()calls flanking a hardcoded<a>tag. This is an i18n anti-pattern: translators cannot reorder the inline link within the sentence, which is required in many languages where word order differs from English./* translators: */comment in the email provider used$1$s/$2$sinstead of the correct%1$s/%2$sformat, causing translation extraction tools (WP-CLI, Poedit, GlotPress) to misidentify the placeholder format.How?
__( ..., 'two-factor' )with appropriate/* translators: */comments documenting each placeholder.__()call with the URL as a%splaceholder. The output is already passed throughwp_kses_post()at the render site, so the HTML anchor in the string is safe.$1$s→%1$s).Testing Instructions
Changelog Entry