Remove legacy webpack DefinePlugin configuration#6904
Remove legacy webpack DefinePlugin configuration#6904sirreal wants to merge 1 commit intoWordPress:trunkfrom
Conversation
WordPress/gutenberg#61486 changed the variables compiled into Gutenberg packages via the webpack DefinePlugin. https://core.trac.wordpress.org/changeset/58193 added the new DefinePlugin configuration, but did not remove the legacy configuration in order to be compatible with new and old Gutenberg versions before the packages were updated. Now that packages have been update, the legacy configuration should be removed. Closes https://core.trac.wordpress.org/ticket/61262. Follow-up to https://core.trac.wordpress.org/changeset/58193.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
#6596 added the configuration. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
|
Committed with https://core.trac.wordpress.org/changeset/58577. |
WordPress/gutenberg#61486 changed the variables
compiled into Gutenberg packages via the webpack DefinePlugin.
https://core.trac.wordpress.org/changeset/58193 added the new
DefinePlugin configuration, but did not remove the legacy configuration
in order to be compatible with new and old Gutenberg versions before the
packages were updated.
Now that packages have been update, the legacy configuration should be
removed.
Follow-up to https://core.trac.wordpress.org/changeset/58193.
Trac ticket: https://core.trac.wordpress.org/ticket/61262
Testing
You can confirm that these variables have been replaced during build and do not appear in compiled source:
You can see they are in the packages:
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.