[PROD-68522] bump joi version to 18.0.2 and remove node v22 test strategy from matrix #425
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CharisVrettos
requested review from
echetzakis,
jgerbe,
klesgidis,
kzacharakis,
nikosd23 and
stavros-wb
as code owners
CharisVrettos
changed the title
CharisVrettos
commented
Jan 7, 2026
| strategy: | ||
| matrix: | ||
| node-version: [18.x, 20.x, 22.x] | ||
| node-version: [18.x, 20.x] |
Contributor
Author
There was a problem hiding this comment.
this should be removed since in node 22 there are breaking changes and the code needs to be changed in order for node 22 to be supported. thus at the moment tests should not run with node 22
Contributor
There was a problem hiding this comment.
@CharisVrettos please revert this and rebase with latest master, this should be fixed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.