DOC-18493 Internationalize the date and time string #208
+6
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Internationalize the date and time string. Really this is just internationalizing the comma between the parts.
Changes
We previously internationalized the
YesterdayandTodaymessages. The date and time string is already using intl methods to format the date and time portions of the string, but is using a static${date}, ${time}composition to combine them. Move that string to a parameterized internationalization string.This may not actually be necessary, but my understanding is that not all languages would necessarily use the same punctuation to combine these two parts.
Release Notes
Review
See CONTRIBUTING.md for more details on review types (+1 / QA +1 / +10) and code review process.
Please review:
QA Checklist
Merge Checklist
While we perform many automated checks before auto-merging, some manual checks are needed: