[feature]-add-precision-flag-for-z#76
Open
eatyourpeas wants to merge 2 commits intoWorldHealthOrganization:masterfrom
Open
[feature]-add-precision-flag-for-z#76eatyourpeas wants to merge 2 commits intoWorldHealthOrganization:masterfrom
eatyourpeas wants to merge 2 commits intoWorldHealthOrganization:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for creating this very useful package. Our use case at the Royal College of Paediatrics and Child Health in the UK involves calculating z scores from growth data to greater than 2 decimal places. Although nowhere is this requested on your issue page, might you consider reviewing/accepting this pull request to include this feature?
It adds a new optional parameter:
z_precisionwhere the user passes in the number of decimal places they require in the response (defaults to2Lif the flag is left empty). We have included some tests in your test suite for the new behaviour including tests in case users pass in negative value or non-integer values.If you are happy with this we have also created a similar feature for anthroplus and are very happy to submit if you would consider reviewing that also.