WIP: New feature - Sub-tree flattening and filtering for Rest2LDAP collection sub-resources#9
Open
GuyPaddock wants to merge 13 commits intoWrenSecurity:mainfrom
Open
Conversation
added 12 commits
October 27, 2017 00:48
As we're going to be making a lot of changes in this area, the tests should at least be legible first.
This adds OUs to the in-memory data model being used by tests, then re-works the existing tests so they continue to pass now that we have that extra data. The next few commits will rely on these OUs to verify that subtree search is working.
Also adds a few accessors in order to faciliate accessors for tests. More work is needed in this area -- FR's code is an inconsistent mess of final classes, fluent factory methods, and accessors with the wrong access level.
Minor tweaks to Javadocs and a little formatting (this class needs a lot more).
Adds the internals needed to apply search filters to collection sub-resources.
- Adds logic to configure base search filter using the new `baseSearchFilter` option for collection sub-resources. - Re-factors a bit of sub-resource configuration to make the code easier to follow and less of a mess.
Kortanul
added
the
enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a WIP for adding the desired feature.
Closes #8.